refactor: Refactor remaining controllers to remove duplicate messenger types#42853
Merged
Conversation
Mrtenz
added
the
no-changelog
Mrtenz
changed the title
Contributor
Builds ready [23844f4]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 23844f4. Configure here.
cryptodev-2s
previously approved these changes
May 21, 2026
mcmire
reviewed
May 21, 2026
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Looks like there are conflicts, but this otherwise looks good.
| | SnapControllerGetPermittedSnapsAction | ||
| | SnapControllerInstallSnapsAction; | ||
|
|
||
| // TODO: Ideally we remove this type, but we request more permissions than |
Mrtenz
force-pushed
the
mrtenz/messenger-types
branch
from
23844f4 to
ded356b
Compare
|
Contributor
Builds ready [06d6126]
⚡ Performance Benchmarks (Total: 🟢 22 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
cryptodev-2s
approved these changes
May 27, 2026
GuillaumeRx
approved these changes
May 27, 2026
FrederikBolding
approved these changes
May 27, 2026
metamaskbot
added
the
release-13.34.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactors all remaining messenger client init files to do the following:
https://consensyssoftware.atlassian.net/browse/WPC-950
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Large but mechanical typing/import refactor across init and messenger factories; runtime delegate behavior is intended unchanged, with compile-time risk if delegated actions diverge from package messenger definitions.
Overview
This PR finishes the messenger-client-init cleanup by sourcing controller messenger types from their owning packages (or local controllers where applicable) instead of duplicating
ReturnType<typeof get*Messenger>aliases undermessengers/.Init modules (
*-init.ts/ tests) now import*ControllerMessengernext to the controller from@metamask/*(e.g. assets, accounts, keyring, multichain). Messenger factories useMessengerActions/MessengerEventsonRootMessenger, construct messengers with the non-genericnew Messenger({ namespace, parent }), and return the package-defined messenger type while keeping existingdelegatewiring. Barrel files drop re-exports of controller messenger types and keep only init messenger types where still defined locally.Notable renames/imports:
CurrencyRateMessengerreplaces the localCurrencyRateControllerMessengername;InstitutionalSnapControllerMessengeris imported from the extension controller module. A few spots still use extension-specific messenger shapes (e.g.PermissionController,PerpsController) with TODOs where the package type is narrower than runtime delegation.Reviewed by Cursor Bugbot for commit 06d6126. Bugbot is set up for automated code reviews on this repo. Configure here.